This repository was archived by the owner on Aug 23, 2019. It is now read-only.
feat: update identify to include supported protocols#311
Merged
Conversation
ghost
assigned
jacobheun
changed the title
This was referenced Mar 20, 2019
alanshaw
approved these changes
Mar 20, 2019
vasco-santos
approved these changes
Mar 20, 2019
Member
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
LGTM! Do not forget to update the package.json
test: verify protocols for both peers
jacobheun
force-pushed
the
feat/identify
branch
from
e454518 to
a66b5f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leverages an updated version of libp2p-identify to store and retrieve the protocols for peers on connection.
Replaces #307, Resolves #304
Depends on libp2p/js-libp2p-identify#51
Requires #310 as it's rebased from it to avoid conflicts